Skip to content

Tune parameters to reduce intermittent failures in S3 TM pauseAndResume integ test #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Tune parameters to reduce intermittent failures in S3 TM pauseAndResume integ test #6336

wants to merge 4 commits into from

Conversation

alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Aug 12, 2025 •
edited
Loading

Tune parameters to reduce intermittent failures in S3TransferManagerDownloadPauseResumeIntegrationTest.pauseAndResume_ObjectNotChanged_shouldResumeDownload integration test.

Motivation and Context

Depending on the timing of waitUntilFirstByteBufferDelivered, the entire file may have been downloaded causing the assertThat(bytesTransferred).isLessThan(sourceFile.length()) to fail.

Modifications

This PR changes three paramters:

  1. Set maxConcurrency to 1 for the CRT client.
  2. Increase the file size from 24 mb to 50.
  3. Decrease the waiter time from 100ms to 10ms.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner August 12, 2025 22:29
@alextwoods alextwoods added the changelog-not-required Indicate changelog entry is not required for a specific PR label Aug 12, 2025
@alextwoods alextwoods changed the title Temporarily comment out s3 TM pauseAndResume integ test Tune parameters to reduce intermittent failures in S3 TM pauseAndResume integ test Aug 13, 2025
@alextwoods alextwoods added this pull request to the merge queue Aug 13, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 13, 2025
@alextwoods
Tune parameters to reduce intermittent failures in S3 TM pauseAndResu…
e6ac726 
…me integ test (#6336)

* Fix flaky s3 TM pauseAndResume integ test

* Comment out entire test

* Tune paramters to reduce flakiness
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
@alextwoods alextwoods added this pull request to the merge queue Aug 13, 2025
@alextwoods alextwoods removed this pull request from the merge queue due to a manual request Aug 13, 2025
@alextwoods alextwoods enabled auto-merge August 13, 2025 18:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.6% Coverage on New Code (required ≥ 80%)
27.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@alextwoods alextwoods added this pull request to the merge queue Aug 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
@alextwoods alextwoods added this pull request to the merge queue Aug 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
@alextwoods alextwoods mentioned this pull request Aug 14, 2025
Merged
11 tasks
@alextwoods
Copy link
Contributor Author

This was merged as part of #6343

@alextwoods alextwoods closed this Aug 14, 2025
@github-actions GitHub Actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2025
@alextwoods alextwoods deleted the alexwoo/fix-s3-integ branch August 15, 2025 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidh44 davidh44 davidh44 approved these changes

Assignees
No one assigned
Labels
changelog-not-required Indicate changelog entry is not required for a specific PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alextwoods @davidh44